Commit Graph

60 Commits

Author SHA1 Message Date
Nils Dagsson Moskopp
adf738854a
Fix mob-in-boat crash in Minetest 5.5-dev
In Minetest 5.4.1, calling get_player_control() on a mob returned the
empty string. Minetest commit 5eb45e1ea03c6104f007efec6dd9c351f310193d
changed this, so now calling get_player_control() on a mob returns nil.

As mcl_boats defines boats that can have a player or a mob as a driver,
code like the following crashes with a changed get_player_control() API:

local ctrl = driver:get_player_control()
if ctrl.sneak then
    detach_object(driver, true)
end

Furthermore, once a world has crashed, joining it near a mob that is the
driver of a boat with such control code immediately crashes again.

When I reported this bug to Minetest, several Minetest core developers
stated that they disliked the old API and proposed other return values
for calling a mob's get_player_control() function – all different from
the empty string. Since I have some doubts that this bug will be fixed
in Minetest 5.5.0, boat code must take into account a nil return value.

Minetest issue: https://github.com/minetest/minetest/issues/11989
2022-02-15 11:17:01 +01:00
Nils Dagsson Moskopp
46394e7e1f
Add obsidian boat that always sinks 2021-11-20 09:06:48 +01:00
Elias Fleckenstein
a7bc460fae
Fix boat and enchanting book texture glitches / warnings 2021-11-09 17:39:39 +01:00
AFCMS
2d1a43396f Merge pull request 'Title HUD API' (#1778) from title-API into master
Reviewed-on: https://git.minetest.land/MineClone2/MineClone2/pulls/1778
2021-08-20 12:31:54 +00:00
AFCMS
fe62189019 Update French translation (part 1) 2021-08-13 11:35:18 +02:00
AFCMS
c31c852a6e add documentation 2021-07-20 16:14:34 +02:00
AFCMS
b5f7ae5458 working implementation + support of other mods 2021-07-20 15:47:26 +02:00
Marcin Serwin
0132d0569f Update polish translation of several files 2021-06-02 13:21:19 +02:00
marcin-serwin
cbe8583cef Merge branch 'master' into polish-translation 2021-06-02 10:14:25 +00:00
AFCMS
cd33d406b2 fix many codestyle issues (functions, strings, modpaths) 2021-05-29 16:12:33 +02:00
AFCMS
be9fff4fe2 [mcl_boats] fix warnings 2021-05-25 00:50:04 +02:00
Elias Fleckenstein
a2983e1fda Update boats translation 2021-04-26 10:17:07 +02:00
Elias Fleckenstein
9eba2add3f Rewrite burning API 2021-04-25 13:09:20 +02:00
Marcin Serwin
9472f86025 Fix spellchecking errors 2021-04-12 17:58:04 +02:00
Marcin Serwin
321caa0632 Minor translation fixes 2021-04-12 11:27:41 +02:00
Marcin Serwin
9f7f1f2c89 Add polish translation of mcl_boats 2021-04-11 14:35:35 +02:00
epCode
97424f7d0a Fix #1414 2021-03-30 10:24:39 -07:00
AFCMS
c35dab1d08 try to fix crash 2021-03-30 00:59:52 +02:00
AFCMS
3a514ecdad remove duplicated code 2021-03-30 00:44:38 +02:00
Elias Fleckenstein
6f8d0d4de0 Fix #1375 2021-03-26 17:51:13 +01:00
Elias Fleckenstein
413fbc9c60 Make boats burn (Fix #1318) 2021-03-18 12:31:25 +01:00
AFCMS
6645c4cb30 Really 2021-03-16 17:43:32 +01:00
Elias Fleckenstein
d57db0444f Use mod.conf in all mods, part 1 2021-03-04 15:22:14 +01:00
Elias Fleckenstein
8d5b2ff714 Make boats less annoying on ice 2021-02-27 14:38:53 +01:00
Elias Fleckenstein
0c3ab5843d Make boats go super fast on ice and slightly faster on land 2021-02-24 10:38:49 +01:00
Elias Fleckenstein
0d2950228a Implement #1057 2021-02-24 09:31:27 +01:00
Elias Fleckenstein
2d4b8a8232 Replace usages of get_node_group by get_item_group 2021-02-23 10:25:17 +01:00
Elias Fleckenstein
2d0612fa81 Make boats regenerate health and shake when damaged 2021-02-22 12:43:29 +01:00
Elias Fleckenstein
c9e589b931 Add mcl_burning damage interval 2021-02-18 14:47:35 +01:00
Elias Fleckenstein
9956e267aa Allow for 2 drivers in a boat 2021-01-31 12:54:40 +01:00
Elias Fleckenstein
e66d66caf9 Fix #399 2021-01-28 19:02:44 +01:00
Elias Fleckenstein
89ce072621 Sneak to dismount when in boat 2021-01-28 17:44:55 +01:00
Elias Fleckenstein
eb01c8e9f8 Give boats HP (Closes #991) 2021-01-24 16:27:04 +01:00
Elias Fleckenstein
507f2d872b Fix #949 2021-01-04 14:21:28 +01:00
kay27
ba51686e6c Russian translation 2020-07-20 00:11:13 +00:00
Wuzzy
c106a62979 Use minetest.is_creative_enabled 2020-07-10 16:45:40 +02:00
Wuzzy
1a0e979b0c Update incomplete license information and credits 2020-05-11 17:18:04 +02:00
Rocher Laurent
4957bd1118 Translate In French 2020-05-03 22:39:07 +02:00
Wuzzy
03a5519d01 Partial German translation of tooltip extensions 2020-03-11 01:44:23 +01:00
Wuzzy
ba74546d48 Add extended tooltips 2020-02-19 04:54:17 +01:00
wuniversales
15481cb24d Add Spanish translation 2020-02-04 21:43:50 +01:00
Wuzzy
4a7aaa9024 Increase boat speed on land 2019-10-02 20:54:06 +02:00
Wuzzy
a9ed14c4af Fix boats moving too fast backwards 2019-10-02 20:51:02 +02:00
Wuzzy
30a954b874 Increase max. speed of boats 2019-09-11 13:33:31 +02:00
Wuzzy
e633f15eed Fix boat behavior a bit when falling on water 2019-09-11 12:50:58 +02:00
Wuzzy
df7acfc8ae Boats: Can place properly at all sides 2019-09-11 12:23:56 +02:00
Wuzzy
b6c3cc0ed7 Tweak boat physics when inside water 2019-09-11 12:11:04 +02:00
Wuzzy
3cba55703a Boats: Allow very slow movement on ground 2019-09-11 11:17:42 +02:00
Wuzzy
1c27cbe4f6 German translation: mcl_mobitems to mcl_potions 2019-03-15 09:50:32 +01:00
Wuzzy
008a1b1cac Add German translation for boats 2019-03-13 05:57:43 +01:00