Commit graph

10787 commits

Author SHA1 Message Date
teknomunk
09307292bc Make sure overworld always gets a sky update regardless of weather, add assert to enforce sky color gets set every update 2024-08-19 03:02:02 +02:00
teknomunk
e407e2e290 Force has_mcl_potions to boolean 2024-08-19 03:02:02 +02:00
teknomunk
87a48270f5 Add mcl_util.to_bool 2024-08-19 03:02:02 +02:00
teknomunk
21a88be2b2 Remove boolean coersion 2024-08-19 03:02:02 +02:00
teknomunk
37ff699a23 Add line break 2024-08-19 03:02:02 +02:00
teknomunk
18266137b2 Make sure clouds don't disappear when entering water 2024-08-19 03:02:02 +02:00
teknomunk
3667feddd3 Address review comments 2024-08-19 03:02:02 +02:00
teknomunk
dc074ff555 Remove debug logging 2024-08-19 03:02:02 +02:00
teknomunk
0e1a2cbc1e Correct conditions for water-air transition forced skycolor update 2024-08-19 03:02:02 +02:00
teknomunk
cb097d9bcd Add minimum time between skycolor updates (default is 250ms, tracked per player) 2024-08-19 03:02:02 +02:00
Wbjitscool
cd213b75f7 Update mods/ENVIRONMENT/mcl_weather/skycolor.lua
adds in sunray shader support for Minetest version 5.9.0
2024-08-19 03:02:02 +02:00
teknomunk
ef58a9809a Remove empty else block, fix up mg_name and add mapgen check to water.lua 2024-08-19 03:02:02 +02:00
teknomunk
3b01fe20ba Remove debug commented out logging, remove extra zero in 24-hour time 2024-08-19 03:02:02 +02:00
teknomunk
d34c804ebf Remove local mod = mcl_weather and replace accesses to variables thru mcl_weather with local variable equivalents 2024-08-19 03:02:02 +02:00
teknomunk
03faa7764d Fix variable name (caused crash) 2024-08-19 03:02:02 +02:00
teknomunk
207c86b813 Fix crash and rearrange code 2024-08-19 03:02:02 +02:00
teknomunk
cf4b1dbd1d Remove END function comment 2024-08-19 03:02:02 +02:00
teknomunk
7811e23611 Convert to use mcl_playerinfo 2024-08-19 03:02:02 +02:00
teknomunk
24ff7347b2 Further cleanup 2024-08-19 03:02:02 +02:00
teknomunk
820848fb2e Address review comments 2024-08-19 03:02:02 +02:00
teknomunk
f2a638f8e9 Fix random crash in darkness effect in mcl_potions, finish refactoring of mcl_weather.skycolor that also makes darkness effect more reliable 2024-08-19 03:02:02 +02:00
teknomunk
161dd7d379 Start refactor 2024-08-19 03:02:02 +02:00
cora
15fa3ff775 Fix crash when growing kelp into water logged mangrove roots 2024-08-18 19:21:19 +02:00
WillConker
11168f226a Revert "WaterLoggedRootsKelpFix (#3994)"
This reverts commit a425d359f5.
2024-08-18 19:21:19 +02:00
teknomunk
2ad59c6df9 Stop lightning striking positions that don't have rain (#4386)
Stops lighting from being able to strike in locations where rain doesn't occur, but allows lightning in adjacent areas where is allowed.

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4386
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: teknomunk <teknomunk@protonmail.com>
Co-committed-by: teknomunk <teknomunk@protonmail.com>
2024-08-18 12:05:35 +02:00
the-real-herowl
948da34755 Readded missing stairs and slabs (#4601)
Also *probably* fixed their blast res and hardness

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4601
Reviewed-by: Mikita Wiśniewski <rudzik8@protonmail.com>
Co-authored-by: the-real-herowl <wiktor_t-i@proton.me>
Co-committed-by: the-real-herowl <wiktor_t-i@proton.me>
2024-08-18 08:45:49 +02:00
WillConker
406e0e8169 Made soul speed and depth strider speed boosts additive instead of exclusive (#4422)
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4422
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: WillConker <waj01@joanes.net>
Co-committed-by: WillConker <waj01@joanes.net>
2024-08-18 06:25:04 +02:00
William Goodspeed
a6136ad158 Removing absorption bar on damage disabled servers
The absorption effect won't work on damage disabled servers and the
health bar and hunger bar is also hidden leaving the absorption bar
alone which makes it look not good. So not initializing it on those
servers might be a good idea.
2024-08-18 05:48:37 +02:00
William Goodspeed
77bcf6cff3 Allowing `hb.change_bar' called with hudbar uninitialized
Calling `hb.change_bar' with hunger bar on damage disabled server
will crash the server. To not overload other functions to check
`enable_damage' over and over, simply make `hb.change_bar' able to be
called with uninitialized identifiers. #4586
2024-08-18 05:48:37 +02:00
WillConker
293eb6d021 Stop tnt colliding with entities (#4476)
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4476
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: WillConker <waj01@joanes.net>
Co-committed-by: WillConker <waj01@joanes.net>
2024-08-18 05:40:25 +02:00
seventeenthShulker
f8fcd9954f Add back *some* changes that I reverted; and fix typo "Cherry Gate" 2024-08-18 04:47:19 +02:00
seventeenthShulker
8b9666137d All wood-type and nether-type fences now match material's blast resistance 2024-08-18 04:47:19 +02:00
seventeenthShulker
b3087118fa Fix Gilded Blackstone blast res. (now 6) 2024-08-18 04:47:19 +02:00
seventeenthShulker
b79a19f4d6 Add crimson/warped planks (_hyphae_wood) blast res
Relates to (#4414)
2024-08-18 04:47:19 +02:00
seventeenthShulker
b0b5cc1265 Remaining stairs/slabs inherit properties instead of hardcoding
- Fix smooth quartz attributes
- Alternative recipes for (red) sandstone, quartz, purpur slabs/stairs have been added explicitly
2024-08-18 04:47:19 +02:00
seventeenthShulker
b237c4642d Revert "Forgot about blackstone"
I left it in from another branch, didn't want to force push.

This reverts commit 58d2f59192073acf9f55406358bf48244e008b9b.

Revert "Walls use `source` parameter for default hardness and blast resistance"
I left it in from another branch, didn't want to force push.

This reverts commit e8944cc145dc59db53a9368d8ae269edf366e742.

Revert "Fix prismarine bricks and dark variant blast res."
I left it in from another branch, didn't want to force push.

This reverts commit 6125d625bc6ce15644cf8b579599f75da5bffd07.

Revert "Un-hardcode blast resistance, hardness for walls,"
I left it in from another branch, didn't want to force push.

This reverts commit 26e873703151bc4bfaf7588ad1e3afa731a05fbd.

Revert "All wood-type and nether-type fences now match material's blast resistance"
I left it in from another branch, didn't want to force push.

This reverts commit a1e20f29162462120fb1c046c2d34f8fcebfb413.
2024-08-18 04:47:19 +02:00
seventeenthShulker
49b2491b70 Fix the other bed node 2024-08-18 04:47:19 +02:00
seventeenthShulker
0408f9c3d8 Update hardness and blast res for value not matching the wiki
- Notably, smooth sandstone (and red) is much more durable than other sandstone variants
- Ender chest isn't actually more explosion resistant than obsidian, hmm
2024-08-18 04:47:12 +02:00
seventeenthShulker
cbafdfa585 Make monster eggs' hardness consistent with MC
Change blast resistance to 0.75, add an optional hardness override parameter, because cobble is unique here

(Still instant-minable, this is a separate issue)
2024-08-18 04:46:19 +02:00
seventeenthShulker
2312989503 Fix several hardness and blast resistance values 2024-08-18 04:46:19 +02:00
seventeenthShulker
1471ad7181 Un-hardcode most slabs and stairs 2024-08-18 04:46:19 +02:00
seventeenthShulker
38d7609173 Forgot about blackstone 2024-08-18 04:46:19 +02:00
seventeenthShulker
5bce56cdd6 Walls use source parameter for default hardness and blast resistance
If no `source` given, fallbacks are 2 and 6 respectively
2024-08-18 04:46:19 +02:00
seventeenthShulker
7a05c32198 Fix prismarine bricks and dark variant blast res.
Should be 6 like regular prismarine
2024-08-18 04:46:19 +02:00
seventeenthShulker
ff386e395f Un-hardcode blast resistance, hardness for walls,
now only based on their material
2024-08-18 04:46:19 +02:00
William Goodspeed
c03f9abd18 Fix the placement check of ladder
The old code takes the first return val of `minetest.item_place_node'
which is `itemstack'. Therefore, the variable `success' in the old code
is always true. The new code takes the second val which will be nil if
an invalid node placement occured.

This check is necessary since the ladder may be placed in the front of
pointed block while there is a node with hole (slabs, fences etc.) at
the same place resulting an invalid placement and sound played when
it shouldn't be played.
2024-08-17 18:38:01 +02:00
William Goodspeed
9657c9d8bb Make ladder placable on any solid block 2024-08-17 18:38:01 +02:00
blitzdoughnuts
95aadd40b9 Add charcoal blocks as an item (#4589)
Co-authored-by: blitzdoughnuts <NOEMAIL@localhost>
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4589
Reviewed-by: Mikita Wiśniewski <rudzik8@protonmail.com>
Co-authored-by: blitzdoughnuts <doughnutsblitz@disroot.org>
Co-committed-by: blitzdoughnuts <doughnutsblitz@disroot.org>
2024-08-16 22:28:08 +02:00
THE-NERD2
86e3446407 Update mount.lua to fix horse riding problem (#4580)
Previously, horses would continue to move even after the movement key was released. This was because mcl_mobs.drive was returning before stopping the horse. This commit makes mcl_mobs.drive stop the horse before returning.

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4580
Reviewed-by: Mikita Wiśniewski <rudzik8@protonmail.com>
Co-authored-by: THE-NERD2 <pdp9729@gmail.com>
Co-committed-by: THE-NERD2 <pdp9729@gmail.com>
2024-08-16 22:21:18 +02:00
goodspeed
ee4d1efaa5 Turn 8 snow layers stacked together into snow block (fixes #4483) (#4591)
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4591
Reviewed-by: Mikita Wiśniewski <rudzik8@protonmail.com>
Co-authored-by: goodspeed <goodspeed@mailo.cat>
Co-committed-by: goodspeed <goodspeed@mailo.cat>
2024-08-16 22:03:01 +02:00
kno10
5e6e4967f0 Fix crying obsidian particles (#4583)
LUAs `math.random(a,b)` expects a and b to be integers. `size` was only randomized once.

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4583
Reviewed-by: Mikita Wiśniewski <rudzik8@protonmail.com>
Co-authored-by: kno10 <erich.schubert@gmail.com>
Co-committed-by: kno10 <erich.schubert@gmail.com>
2024-08-16 22:01:19 +02:00
kno10
df60ec947d Not all mangrove trees were post-processed (#4584)
Mangrove tree variants 4, 5 and bees nest were not post processed with root growth.

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4584
Reviewed-by: Mikita Wiśniewski <rudzik8@protonmail.com>
Co-authored-by: kno10 <erich.schubert@gmail.com>
Co-committed-by: kno10 <erich.schubert@gmail.com>
2024-08-16 21:58:04 +02:00
kno10
02cb0818a1 When chests explode due to TNT (and likely creepers), the game crashes (#4577)
because of an undefined variable.

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4577
Reviewed-by: Mikita Wiśniewski <rudzik8@protonmail.com>
Co-authored-by: kno10 <erich.schubert@gmail.com>
Co-committed-by: kno10 <erich.schubert@gmail.com>
2024-08-07 13:07:48 +02:00
kno10
77382d930e Typo in setting name, default should be false (#4492)
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4492
Reviewed-by: Mikita Wiśniewski <rudzik8@protonmail.com>
Co-authored-by: kno10 <kno10@noreply.git.minetest.land>
Co-committed-by: kno10 <kno10@noreply.git.minetest.land>
2024-08-03 17:52:51 +02:00
WillConker
6c614d8376 Added line breaks in water freezing condition 2024-08-03 14:21:33 +02:00
WillConker
a785be59d9 Changed node light check to artificial light so that water can freeze in the day 2024-08-03 14:21:33 +02:00
cora
f23014005f Only freeze water under open air
and if light level < 10
2024-08-03 14:21:33 +02:00
cora
c2098d777f Prevent water freezing and ice melting ABMs from fighting 2024-08-03 14:21:33 +02:00
cora
dc07eea590 Freeze water in cold areas 2024-08-03 14:21:33 +02:00
OgelGames
0012bdb71e Clear itemstring when picking up or merging items (#4530)
Prevents possible item duplication with other mods. Matches the behavior of the default `__builtin:item`.

See also https://github.com/mt-mods/pipeworks/issues/130

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4530
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: OgelGames <ogelgames@noreply.git.minetest.land>
Co-committed-by: OgelGames <ogelgames@noreply.git.minetest.land>
2024-07-31 03:26:28 +02:00
kno10
b8d7139792 Fix iron golem attack animation (#4542)
C.f. MCLA

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4542
Reviewed-by: the-real-herowl <the-real-herowl@noreply.git.minetest.land>
Co-authored-by: kno10 <erich.schubert@gmail.com>
Co-committed-by: kno10 <erich.schubert@gmail.com>
2024-07-31 03:18:53 +02:00
WillConker
cddc1982be Fix first loot pool not being used in shipwrecks or ocean temples (#4523)
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4523
Reviewed-by: Mikita Wiśniewski <rudzik8@protonmail.com>
Co-authored-by: WillConker <willconker@noreply.git.minetest.land>
Co-committed-by: WillConker <willconker@noreply.git.minetest.land>
2024-07-31 03:00:27 +02:00
kno10
9595b0df59 Inconsistent bed bouncyness, make top match bottom (#4495)
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4495
Reviewed-by: teknomunk <teknomunk@protonmail.com>
Co-authored-by: kno10 <kno10@noreply.git.minetest.land>
Co-committed-by: kno10 <kno10@noreply.git.minetest.land>
2024-07-31 02:58:38 +02:00
WillConker
ff21d1eab1 Make eggs spawn chicks when hitting entities (#4484)
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4484
Reviewed-by: Mikita Wiśniewski <rudzik8@protonmail.com>
Co-authored-by: WillConker <willconker@noreply.git.minetest.land>
Co-committed-by: WillConker <willconker@noreply.git.minetest.land>
2024-07-31 02:57:20 +02:00
WillConker
9d5b46c28a Slow ender dragon regeneration (#4481)
Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4481
Reviewed-by: Mikita Wiśniewski <rudzik8@protonmail.com>
Co-authored-by: WillConker <waj01@joanes.net>
Co-committed-by: WillConker <waj01@joanes.net>
2024-07-31 02:56:33 +02:00
kno10
80a6a6efb0 Choose direction vectors uniformly for spawning (#4467)
The previous code was biased towards placing mobs on top or below the
player, because it chose the theta inclination angle uniformly,
but the sphere is more narrow at the top and bottom.

This code is also simpler.

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4467
Reviewed-by: teknomunk <teknomunk@protonmail.com>
Co-authored-by: kno10 <erich.schubert@gmail.com>
Co-committed-by: kno10 <erich.schubert@gmail.com>
2024-07-31 02:30:29 +02:00
Mikita Wiśniewski
567d112942 Fix deprecated get_metadata() usage
Items are instead written as a serialized string into ItemStackMetaRef, and read from there as well. Old itemstacks get converted to the new format automatically.
2024-07-31 02:27:26 +02:00
Mikita Wiśniewski
347305eaea Fix ender chests rotate crash 2024-07-31 02:27:26 +02:00
Mikita Wiśniewski
508bc19f6a Remove nil fields from trapped chest definition 2024-07-31 02:27:26 +02:00
Mikita Wiśniewski
c1e9e4b1a2 Fix typos in API.md 2024-07-31 02:27:26 +02:00
Mikita Wiśniewski
7bf15642ca Resolve teknomunk's comments 2024-07-31 02:27:26 +02:00
Mikita Wiśniewski
f1fa6240bb Fix shift-clicking and a few luacheck warnings 2024-07-31 02:27:26 +02:00
Mikita Wiśniewski
c5bc6ff189 Cleanup comments (don't use \=, it's annoying) 2024-07-31 02:27:26 +02:00
Mikita Wiśniewski
70e903b716 Simplify double inventory inv logic 2024-07-31 02:27:26 +02:00
Mikita Wiśniewski
209b24a2fb Move LBMs out of init.lua and fix API.md 2024-07-31 02:27:26 +02:00
cora
ac05f8bad6 Remove unused variables in chests example.lua 2024-07-31 02:27:26 +02:00
Mikita Wiśniewski
76cff76d91 Add an introduction text to API.md 2024-07-31 02:27:26 +02:00
Mikita Wiśniewski
49b6d09985 Add documentation (README.md, API.md) 2024-07-31 02:27:26 +02:00
Mikita Wiśniewski
a66c35a9ea Fix double chests once more (hoppers this time) 2024-07-31 02:27:26 +02:00
Mikita Wiśniewski
a28e55160f Make the chest opening/closing sound customizable + fix double chests 2024-07-31 02:27:26 +02:00
Mikita Wiśniewski
6bbb6b8dec Add title field for mcl_chests.register_chest 2024-07-31 02:27:26 +02:00
Mikita Wiśniewski
b4b5bf8391 Move some groups (api.lua → chests.lua) 2024-07-31 02:27:26 +02:00
Mikita Wiśniewski
16dd8694a6 Refactor mcl_chests.register_chest AGAIN + cleanup
Now you can define custom groups for the chests, as shown in the trapped
chests example (now they show up under "Mechanisms" tab in creative!).

I'm a bit suspicious of the new return-wrapped functions, as in *they
might break under some circumstances I didn't observe*. It will require
some heavy testing to make sure nothing crashes in the future.

Also, `on_rightclick` for double chests is something I really want to
return-wrap as well, but failed to do so. 🤷
2024-07-31 02:27:26 +02:00
Jürgen Rühle
7a5ee4e6e2 Better detection of properly serialized data
Remove entity if initialization data is missing. Downgrade message in that case
to a warning.
2024-07-31 02:27:26 +02:00
Jürgen Rühle
d0d9600709 Fix invisible chests
Pass chest entity initialization data to on_activate as staticdata so
initialization is atomic, preventing premature deletion of chest entity
by concurrent server steps.
2024-07-31 02:27:26 +02:00
cora
709b73295c Fix meta:set_string being called with nil 2024-07-31 02:27:26 +02:00
Mikita Wiśniewski
1d77017ca9 Refactor mcl_chests.register_chest and clean-up 2024-07-31 02:27:26 +02:00
Mikita Wiśniewski
d6d64d8837 Fix long doc strings 2024-07-31 02:27:26 +02:00
Mikita Wiśniewski
e771f0e3ff Split ITEMS/mcl_chests/init.lua (fixes #281)
Shulker boxes can now be rotated.

The TODO will now be transferred to PR.
2024-07-31 02:27:26 +02:00
Mikita Wiśniewski
b10bfe27ce Clean-up ITEMS/mcl_chests code, part 2
Chest tile management has been reorganized to use postfixes, some slight
formatting fixes applied here and there, and roughly marked down where
the new files should (ideally) begin and end.
2024-07-31 02:27:26 +02:00
Mikita Wiśniewski
d5b3a6f658 Clean-up ITEMS/mcl_chests code, part 1
Amongst other changes:
- mcl_chests.register_chest function has been exposed. The API is still
  too terrible to call it quits though, I definitely want all these
  parameters passed to be part of a key-value table.
- Added a TODO list at the top of the file. Don't worry, I'll remove it
  once I'm done. It's more just for my convenience than anything.
2024-07-31 02:27:26 +02:00
JoseDouglas26
f7ee3b59d7 Changes on slab placement checks (#4317)
Fixed slab placement being not allowed when it should be allowed.

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4317
Reviewed-by: Mikita Wiśniewski <rudzik8@protonmail.com>
Co-authored-by: JoseDouglas26 <josedouglas20002014@gmail.com>
Co-committed-by: JoseDouglas26 <josedouglas20002014@gmail.com>
2024-07-31 00:11:22 +02:00
teknomunk
bb9ed4498b Address review comments 2024-06-26 06:52:26 -05:00
teknomunk
94981d9c09 Add return for get_staticdata 2024-06-26 12:23:30 +02:00
teknomunk
7ae05d9c06 Add persistence to XP orbs, cleanup xp_to_size 2024-06-26 12:23:30 +02:00
teknomunk
177e8f4b9d Code cleanup 2024-06-26 12:23:30 +02:00
the-real-herowl
8bbceddbc2 Updated release credits and set version for hotfix v0.87.2 2024-06-24 03:28:19 +02:00
the-real-herowl
6e70c760d6 Fix some formspecs on mobile (#4456)
This should allow renaming items on the anvil when using mobile. This also may improve mobile craftguide experience.

Reviewed-on: https://git.minetest.land/VoxeLibre/VoxeLibre/pulls/4456
Co-authored-by: the-real-herowl <wiktor_t-i@proton.me>
Co-committed-by: the-real-herowl <wiktor_t-i@proton.me>
2024-06-24 03:26:02 +02:00
teknomunk
3928e12634 Fix two more crashes, stray space 2024-06-24 03:06:26 +02:00
teknomunk
304550d90c Fix parameter name 2024-06-24 03:06:26 +02:00