Commit Graph

43 Commits

Author SHA1 Message Date
𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟
a620d24ec8 Fix a number of crashes involving unknown nodes, also fix fishbuckets on_place (#3914)
Fixes: #3913 #3915

~~You can reproduce the crash by placing a fish bucket on top snow above an unknown node.

I also noticed that the code always uses pointed_thing.above so I fixed that and also added a function to mcl_utils to figure out where a node should be placed (either above or below). Looks like the rest of the code could also use improvement but at least it does not crash now.~~

Cora fixed a bunch of related crashes in Mineclona so I am replacing my commit and cherry picking all her commits here.
https://codeberg.org/mineclonia/mineclonia/pulls/549

Here is the list of fixes from that PR:
- Crash when placing snow layer on unknown nodes
- Crash when snow layers on unknown nodes are flooded
- Crash when placing fishbucket on snow on top of unknown nodes
- Crash when placing chorus flower and stem on unknown
- Crash when placing mob spawners on unknown
- The fishbucket on place to actually replace buildable_to

Co-authored-by: cora <coradelamouche@gmx.ch>
Reviewed-on: https://git.minetest.land/MineClone2/MineClone2/pulls/3914
Reviewed-by: ancientmarinerdev <ancientmariner_dev@proton.me>
Co-authored-by: 𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟 <mrrar@noreply.git.minetest.land>
Co-committed-by: 𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟 <mrrar@noreply.git.minetest.land>
2023-09-29 18:47:07 +00:00
Emojigit
d2f7d31360
Fix warning in mcl_end
This fixes:
```
2021-07-10 10:00:58: WARNING[Main]: get_mapgen_params is deprecated; use get_mapgen_setting instead (at .../../games/MineClone2/mods/ITEMS/mcl_end/chorus_plant.lua:456)
```
2021-07-10 10:16:55 +08:00
AFCMS
cd33d406b2 fix many codestyle issues (functions, strings, modpaths) 2021-05-29 16:12:33 +02:00
AFCMS
d3a237384d [mcl_end] fix warnings 2021-05-25 08:40:21 +02:00
AFCMS
56310a3624 [mcl_end] fix some warnings 2021-05-22 23:56:52 +02:00
kay27
f3c540af5d [mcl_mapgen_core, mcl_biomes] Make chorus growth deterministic 2021-05-10 02:24:52 +04:00
AFCMS
8f30e223e2 I hate reverting something xD 2021-03-16 17:39:06 +01:00
Wuzzy
2e9231ac56 Remove dead chorus flower from Creative 2020-08-05 21:00:30 +02:00
Wuzzy
ed6604ee56 Remove incorrect dead chorus flower tooltip 2020-08-05 20:44:41 +02:00
Wuzzy
402205d1ed Do not hide alive chorus flower in Creative 2020-08-05 20:40:34 +02:00
Elias Åström
a8eca09822 Fix on_blast for chorus flower crashing 2020-07-27 19:44:55 +02:00
Wuzzy
c106a62979 Use minetest.is_creative_enabled 2020-07-10 16:45:40 +02:00
Wuzzy
6a6e294c19 Fix blast not removing chorus plant 2020-06-07 21:31:52 +02:00
Elias Åström
6315490b14 Update the rest of the blast resistance values
The values have been updated according to this list:

https://minecraft.gamepedia.com/Module:Blast_resistance_values
2020-04-19 13:08:36 +02:00
Wuzzy
c5e4ec5e27 Use ephemeral sounds 2020-04-07 00:55:45 +02:00
Wuzzy
ba74546d48 Add extended tooltips 2020-02-19 04:54:17 +01:00
Wuzzy
28505885f2 Add on_blast handling to chorus plant 2019-12-09 21:06:17 +01:00
ZedekThePD
b71cf5e9c2 Boost performance of chorus plant digging 2019-12-09 20:44:55 +01:00
Jared Moody
89ba84a456 Fixes #583 - Eating chorus plant restores 4 HP 2019-12-09 08:24:38 +01:00
Wuzzy
36adba2e0b Add chorus plant stem to deco_block group 2019-06-13 20:44:04 +02:00
Wuzzy
8830edfdf9 Add chorus plant stem usagehelp 2019-05-04 13:39:11 +02:00
Wuzzy
80ee8172fe Only allow placement of chorus stems on valid node 2019-05-04 13:33:37 +02:00
Wuzzy
b0c457f2ec Fix chorus plant stems not break in protected land 2019-05-04 12:59:53 +02:00
Wuzzy
3cdf570460 The End: Remove 2 helper recipes, update help 2019-03-10 03:22:35 +01:00
Wuzzy
022f627fd0 Drop attached chorus plant nodes if detached 2019-03-10 02:58:53 +01:00
Wuzzy
740e87cd81 Add FIXME for chorus plants 2019-03-10 01:05:06 +01:00
Wuzzy
655a240107 Chorus plant: Prevent double placement of flowers 2019-03-09 23:19:14 +01:00
Wuzzy
7a4aeb6625 Generate chorus plants in the End 2019-03-09 21:02:40 +01:00
Wuzzy
a29626881f New translation system, part 7: Items, part 3 2019-03-08 00:00:09 +01:00
Wuzzy
c1bc7a8fae Chorus fruit keeps u safe from damaging blocks 2019-02-19 03:42:50 +01:00
Wuzzy
371bc0cb76 Creative categories: book, chorusfruit, endpearl 2019-02-06 12:04:58 +01:00
Wuzzy
0876e76b40 Fix crash when using chorus fruit on cake 2019-02-05 22:05:56 +01:00
Wuzzy
9ed83bd196 Drop food eating limits in Creative Mode 2019-02-05 21:51:40 +01:00
Wuzzy
101285d04d Fix chorus fruit not working with damage on 2018-01-23 04:24:05 +01:00
Wuzzy
232dbca783 Add sound for chorus fruit teleport 2018-01-23 04:18:19 +01:00
Wuzzy
d36ec8ee17 Update chorus fruit help 2018-01-23 04:01:59 +01:00
Wuzzy
e3c207c312 Fix no placement sound of chorus flower 2018-01-23 02:56:46 +01:00
Wuzzy
92a595e9e7 Copy-editing of chorus plant help 2018-01-23 02:51:58 +01:00
Wuzzy
3399f3b0c2 Add chorus plant help 2018-01-23 02:44:05 +01:00
Wuzzy
88d1570f5b Drop TODO in chorus_plant.lua 2018-01-23 02:03:57 +01:00
Wuzzy
3136c0f119 More mcl_end refactoring 2018-01-23 01:57:32 +01:00
Wuzzy
af1465ab0c Tweak chorus flower aging 2018-01-23 01:54:59 +01:00
Wuzzy
5e47bce74e Refactor mcl_end 2018-01-23 01:53:43 +01:00