Minetest/VoxeLibre
2
0
Fork 0
mirror of https://git.minetest.land/VoxeLibre/VoxeLibre.git synced 2024-11-22 10:31:06 +01:00
Code Issues Projects Releases Packages Wiki Activity

fix warning / wrong usage of on_construct in torches

Browse source
This commit is contained in:
cora 2022-10-14 02:16:27 +02:00
parent 40fb4a1299
commit a7e12e268c
1 changed files with 15 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
mods/ITEMS/mcl_torches/api.lua
View file

@ -12,7 +12,7 @@ local smoke_pdef = {
} }
local function spawn_flames_floor(pos, flame_type) local function spawn_flames_floor(pos, flame_type)
-- Flames -- Flames
mcl_particles.add_node_particlespawner(pos, { mcl_particles.add_node_particlespawner(pos, {
amount = 8, amount = 8,
@ -36,7 +36,7 @@ local function spawn_flames_wall(pos, flame_type)
--local minrelpos, maxrelpos --local minrelpos, maxrelpos
local node = minetest.get_node(pos) local node = minetest.get_node(pos)
local dir = minetest.wallmounted_to_dir(node.param2) local dir = minetest.wallmounted_to_dir(node.param2)
local smoke_pdef = table.copy(smoke_pdef) local smoke_pdef = table.copy(smoke_pdef)
if dir.x < 0 then if dir.x < 0 then
@ -81,7 +81,7 @@ local function set_flames(pos, flame_type, attached_to)
spawn_flames_wall(pos, flame_type) spawn_flames_wall(pos, flame_type)
end end
end end
return function(pos) return function(pos)
spawn_flames_floor(pos, flame_type) spawn_flames_floor(pos, flame_type)
end end
@ -150,7 +150,7 @@ function mcl_torches.register_torch(def)
groups.destroy_by_lava_flow = 1 groups.destroy_by_lava_flow = 1
groups.dig_by_piston = 1 groups.dig_by_piston = 1
groups.flame_type = def.flame_type or 1 groups.flame_type = def.flame_type or 1
local floordef = { local floordef = {
description = def.description, description = def.description,
_doc_items_longdesc = def.doc_items_longdesc, _doc_items_longdesc = def.doc_items_longdesc,
@ -227,7 +227,11 @@ function mcl_torches.register_torch(def)
return itemstack return itemstack
end, end,
on_rotate = false, on_rotate = false,
on_construct = def.particles and set_flames(pos, def.flame_type, "floor"), on_construct = function(pos)
if def.particles then
set_flames(pos, def.flame_type, "floor")
end
end,
on_destruct = def.particles and remove_flames, on_destruct = def.particles and remove_flames,
} }
minetest.register_node(itemstring, floordef) minetest.register_node(itemstring, floordef)
@ -247,13 +251,18 @@ function mcl_torches.register_torch(def)
light_source = def.light, light_source = def.light,
groups = groups_wall, groups = groups_wall,
drop = def.drop or itemstring, drop = def.drop or itemstring,
use_texture_alpha = "clip",
selection_box = { selection_box = {
type = "wallmounted", type = "wallmounted",
wall_side = {-0.5, -0.3, -0.1, -0.2, 0.325, 0.1}, wall_side = {-0.5, -0.3, -0.1, -0.2, 0.325, 0.1},
}, },
sounds = def.sounds, sounds = def.sounds,
on_rotate = false, on_rotate = false,
on_construct = def.particles and set_flames(pos, def.flame_type, "wall"), on_construct = function(pos)
if def.particles then
set_flames(pos, def.flame_type, "wall")
end
end,
on_destruct = def.particles and remove_flames, on_destruct = def.particles and remove_flames,
} }
minetest.register_node(itemstring_wall, walldef) minetest.register_node(itemstring_wall, walldef)