From 78f32d2dd414812462e5d5e7829f2e124aaeb12d Mon Sep 17 00:00:00 2001 From: CyberMango Date: Wed, 18 Jan 2023 23:36:21 +0200 Subject: [PATCH] Removed the approved field from death reasons. This created a strange bug that only death reasons created by mcl_utils.deal_damage were "approved" so only they triggered running the death callbacks, so only they triggered printing a death message. Therefore most deaths did not produce a death message. --- mods/CORE/mcl_damage/init.lua | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/mods/CORE/mcl_damage/init.lua b/mods/CORE/mcl_damage/init.lua index 773e7a43e..8804b8561 100644 --- a/mods/CORE/mcl_damage/init.lua +++ b/mods/CORE/mcl_damage/init.lua @@ -155,7 +155,6 @@ end, true) minetest.register_on_player_hpchange(function(player, hp_change, mt_reason) if not damage_enabled then return 0 end if player:get_hp() > 0 then - mt_reason.approved = true if hp_change < 0 then mcl_damage.run_damage_callbacks(player, -hp_change, mcl_damage.from_mt(mt_reason)) end @@ -163,9 +162,7 @@ minetest.register_on_player_hpchange(function(player, hp_change, mt_reason) end, false) minetest.register_on_dieplayer(function(player, mt_reason) - if mt_reason.approved then - mcl_damage.run_death_callbacks(player, mcl_damage.from_mt(mt_reason)) - end + mcl_damage.run_death_callbacks(player, mcl_damage.from_mt(mt_reason)) minetest.log("action","Player "..player:get_player_name().." died at "..minetest.pos_to_string(vector.round(player:get_pos()))) end)