From 36231241baec051c5b436692c9f248ce01ff53b8 Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Mon, 23 Jan 2023 00:06:46 +0000 Subject: [PATCH 01/25] make hoes effective on warped wart blocks and shroomlight blocks --- mods/ITEMS/mcl_crimson/init.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mods/ITEMS/mcl_crimson/init.lua b/mods/ITEMS/mcl_crimson/init.lua index c9d0a5496..c8b8950a8 100644 --- a/mods/ITEMS/mcl_crimson/init.lua +++ b/mods/ITEMS/mcl_crimson/init.lua @@ -264,14 +264,14 @@ mcl_flowerpots.register_potted_flower("mcl_crimson:warped_roots", { minetest.register_node("mcl_crimson:warped_wart_block", { description = S("Warped Wart Block"), tiles = {"warped_wart_block.png"}, - groups = {handy = 1, hoe = 7, swordy = 1, deco_block = 1}, + groups = {handy = 1, hoey = 7, swordy = 1, deco_block = 1}, _mcl_hardness = 2, }) minetest.register_node("mcl_crimson:shroomlight", { description = S("Shroomlight"), tiles = {"shroomlight.png"}, - groups = {handy = 1, hoe = 7, swordy = 1, deco_block = 1}, + groups = {handy = 1, hoey = 7, swordy = 1, deco_block = 1}, light_source = minetest.LIGHT_MAX, _mcl_hardness = 2, }) From 9e8ed7efc39fc4238f8a628ba793d356f69ac957 Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Mon, 23 Jan 2023 00:11:56 +0000 Subject: [PATCH 02/25] make hoes effective and swords slightly effective on nether wart blocks --- mods/ITEMS/mcl_nether/init.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mods/ITEMS/mcl_nether/init.lua b/mods/ITEMS/mcl_nether/init.lua index d300df5fd..204fcf88d 100644 --- a/mods/ITEMS/mcl_nether/init.lua +++ b/mods/ITEMS/mcl_nether/init.lua @@ -202,7 +202,7 @@ minetest.register_node("mcl_nether:nether_wart_block", { stack_max = 64, tiles = {"mcl_nether_nether_wart_block.png"}, is_ground_content = false, - groups = {handy=1, hoey=1, building_block=1, compostability = 85}, + groups = {handy=1, hoey=7, swordy=1, building_block=1, compostability = 85}, sounds = mcl_sounds.node_sound_leaves_defaults( { footstep={name="default_dirt_footstep", gain=0.7}, From 42eb541eaae587380c317cfc4ca9e471cdb1cec9 Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Mon, 23 Jan 2023 01:28:55 +0000 Subject: [PATCH 03/25] Add sound to warped wart block and shroomlight block --- mods/ITEMS/mcl_crimson/init.lua | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mods/ITEMS/mcl_crimson/init.lua b/mods/ITEMS/mcl_crimson/init.lua index c8b8950a8..7ccc45655 100644 --- a/mods/ITEMS/mcl_crimson/init.lua +++ b/mods/ITEMS/mcl_crimson/init.lua @@ -265,6 +265,7 @@ minetest.register_node("mcl_crimson:warped_wart_block", { description = S("Warped Wart Block"), tiles = {"warped_wart_block.png"}, groups = {handy = 1, hoey = 7, swordy = 1, deco_block = 1}, + sounds = mcl_sounds.node_sound_leaves_defaults(), _mcl_hardness = 2, }) @@ -273,6 +274,7 @@ minetest.register_node("mcl_crimson:shroomlight", { tiles = {"shroomlight.png"}, groups = {handy = 1, hoey = 7, swordy = 1, deco_block = 1}, light_source = minetest.LIGHT_MAX, + sounds = mcl_sounds.node_sound_leaves_defaults(), _mcl_hardness = 2, }) From 62bb7a85ebd07ba662c5644f986cdaebee78490a Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Mon, 23 Jan 2023 02:04:58 +0000 Subject: [PATCH 04/25] Add sounds to weeping vines and twisting vines, updated warped wart block and shroomlight sounds --- mods/ITEMS/mcl_crimson/init.lua | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/mods/ITEMS/mcl_crimson/init.lua b/mods/ITEMS/mcl_crimson/init.lua index 7ccc45655..a32c41511 100644 --- a/mods/ITEMS/mcl_crimson/init.lua +++ b/mods/ITEMS/mcl_crimson/init.lua @@ -113,6 +113,7 @@ minetest.register_node("mcl_crimson:twisting_vines", { climbable = true, buildable_to = true, groups = {dig_immediate=3,vines=1,dig_by_water=1,destroy_by_lava_flow=1,dig_by_piston=1,deco_block=1, shearsy = 1}, + sounds = mcl_sounds.node_sound_leaves_defaults(), selection_box = { type = "fixed", fixed = { -3/16, -0.5, -3/16, 3/16, 0.5, 3/16 }, @@ -169,6 +170,7 @@ minetest.register_node("mcl_crimson:weeping_vines", { climbable = true, buildable_to = true, groups = {dig_immediate=3,vines=1,dig_by_water=1,destroy_by_lava_flow=1,dig_by_piston=1,deco_block=1, shearsy = 1}, + sounds = mcl_sounds.node_sound_leaves_defaults(), selection_box = { type = "fixed", fixed = { -3/16, -0.5, -3/16, 3/16, 0.5, 3/16 }, @@ -265,7 +267,12 @@ minetest.register_node("mcl_crimson:warped_wart_block", { description = S("Warped Wart Block"), tiles = {"warped_wart_block.png"}, groups = {handy = 1, hoey = 7, swordy = 1, deco_block = 1}, - sounds = mcl_sounds.node_sound_leaves_defaults(), + sounds = mcl_sounds.node_sound_leaves_defaults( +{ + footstep={name="default_dirt_footstep", gain=0.7}, + dug={name="default_dirt_footstep", gain=1.5}, + } +), _mcl_hardness = 2, }) @@ -274,7 +281,12 @@ minetest.register_node("mcl_crimson:shroomlight", { tiles = {"shroomlight.png"}, groups = {handy = 1, hoey = 7, swordy = 1, deco_block = 1}, light_source = minetest.LIGHT_MAX, - sounds = mcl_sounds.node_sound_leaves_defaults(), + sounds = mcl_sounds.node_sound_leaves_defaults( +{ + footstep={name="default_dirt_footstep", gain=0.7}, + dug={name="default_dirt_footstep", gain=1.5}, + } +), _mcl_hardness = 2, }) From f97128379849a9490560dd31e222e14ce032ae8a Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Mon, 23 Jan 2023 16:55:18 +0000 Subject: [PATCH 05/25] Add placement sounds to twisting vines and weeping vines --- mods/ITEMS/mcl_crimson/init.lua | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/mods/ITEMS/mcl_crimson/init.lua b/mods/ITEMS/mcl_crimson/init.lua index a32c41511..25fe447db 100644 --- a/mods/ITEMS/mcl_crimson/init.lua +++ b/mods/ITEMS/mcl_crimson/init.lua @@ -129,7 +129,17 @@ minetest.register_node("mcl_crimson:twisting_vines", { if not minetest.is_creative_enabled(clicker:get_player_name()) then itemstack:take_item() end +--placement checks sucess, put twisting vine grow_vines(pos, 1, "mcl_crimson:twisting_vines") +--add sound to vine placement + local idef = itemstack:get_definition() + local itemstack, success = minetest.item_place_node(itemstack, placer, pointed_thing) + if success then + if idef.sounds and idef.sounds.place then + minetest.sound_play(idef.sounds.place, {pos=above, gain=1}, true) + end + end + elseif clicker:get_wielded_item():get_name() == "mcl_bone_meal:bone_meal" then if not minetest.is_creative_enabled(clicker:get_player_name()) then itemstack:take_item() @@ -186,7 +196,17 @@ minetest.register_node("mcl_crimson:weeping_vines", { if not minetest.is_creative_enabled(clicker:get_player_name()) then itemstack:take_item() end +--placement check sucess, grow weeping vine grow_vines(pos, 1, "mcl_crimson:weeping_vines", -1) +--add sound to placement + local idef = itemstack:get_definition() + local itemstack, success = minetest.item_place_node(itemstack, placer, pointed_thing) + if success then + if idef.sounds and idef.sounds.place then + minetest.sound_play(idef.sounds.place, {pos=above, gain=1}, true) + end + end + elseif clicker:get_wielded_item():get_name() == "mcl_bone_meal:bone_meal" then if not minetest.is_creative_enabled(clicker:get_player_name()) then itemstack:take_item() From 70b56d71261af908c1a790851a6fd7b24a6d05e1 Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Mon, 23 Jan 2023 21:30:32 +0000 Subject: [PATCH 06/25] Fix hitbox size for Warped Fungus --- mods/ITEMS/mcl_crimson/init.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mods/ITEMS/mcl_crimson/init.lua b/mods/ITEMS/mcl_crimson/init.lua index 25fe447db..f702d39b6 100644 --- a/mods/ITEMS/mcl_crimson/init.lua +++ b/mods/ITEMS/mcl_crimson/init.lua @@ -76,10 +76,10 @@ minetest.register_node("mcl_crimson:warped_fungus", { walkable = false, groups = {dig_immediate=3,mushroom=1,attached_node=1,dig_by_water=1,destroy_by_lava_flow=1,dig_by_piston=1,enderman_takable=1,deco_block=1}, light_source = 1, ---[[ selection_box = { + selection_box = { type = "fixed", fixed = { -3/16, -0.5, -3/16, 3/16, -2/16, 3/16 }, - },]] + }, node_placement_prediction = "", on_rightclick = function(pos, node, pointed_thing, player, itemstack) if pointed_thing:get_wielded_item():get_name() == "mcl_bone_meal:bone_meal" then From ef1f7b8e2076f28057544ec905d1d6ebb4c87bb4 Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Mon, 23 Jan 2023 22:17:12 +0000 Subject: [PATCH 07/25] make blackstone, basalt, and nether gold ore mineable with a wooden pickaxe Fixes #3287 --- mods/ITEMS/mcl_blackstone/init.lua | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/mods/ITEMS/mcl_blackstone/init.lua b/mods/ITEMS/mcl_blackstone/init.lua index cb6ef5493..c428fe7c6 100644 --- a/mods/ITEMS/mcl_blackstone/init.lua +++ b/mods/ITEMS/mcl_blackstone/init.lua @@ -12,7 +12,7 @@ minetest.register_node("mcl_blackstone:blackstone", { tiles = {"mcl_blackstone_top.png", "mcl_blackstone_top.png", "mcl_blackstone_side.png"}, sounds = mcl_sounds.node_sound_stone_defaults(), is_ground_content = false, - groups = {cracky = 3, pickaxey=2, material_stone=1, cobble=1}, + groups = {cracky = 3, pickaxey=1, material_stone=1, cobble=1}, _mcl_blast_resistance = 6, _mcl_hardness = 1.5, }) @@ -21,7 +21,7 @@ minetest.register_node("mcl_blackstone:blackstone_gilded", { tiles = {"mcl_blackstone_gilded.png"}, sounds = mcl_sounds.node_sound_stone_defaults(), is_ground_content = false, - groups = {cracky = 3, pickaxey=2, material_stone=1, xp=1}, + groups = {cracky = 3, pickaxey=1, material_stone=1, xp=1}, drop = { max_items = 1, items = { @@ -43,7 +43,7 @@ minetest.register_node("mcl_blackstone:nether_gold", { tiles = {"mcl_nether_gold_ore.png"}, sounds = mcl_sounds.node_sound_stone_defaults(), is_ground_content = false, - groups = {cracky = 3, pickaxey=2, material_stone=1, xp=1}, + groups = {cracky = 3, pickaxey=1, material_stone=1, xp=1}, drop = { max_items = 1, items = { @@ -67,7 +67,7 @@ minetest.register_node("mcl_blackstone:basalt_polished", { on_place = mcl_util.rotate_axis, on_rotate = on_rotate, is_ground_content = false, - groups = {cracky = 3, pickaxey=2, material_stone=1}, + groups = {cracky = 3, pickaxey=1, material_stone=1}, _mcl_blast_resistance = 4.2, _mcl_hardness = 1.25, }) @@ -79,7 +79,7 @@ minetest.register_node("mcl_blackstone:basalt", { on_place = mcl_util.rotate_axis, on_rotate = on_rotate, is_ground_content = false, - groups = {cracky = 3, pickaxey=2, material_stone=1}, + groups = {cracky = 3, pickaxey=1, material_stone=1}, _mcl_blast_resistance = 4.2, _mcl_hardness = 1.25, }) @@ -88,7 +88,7 @@ minetest.register_node("mcl_blackstone:basalt_smooth", { tiles = {"mcl_blackstone_basalt_smooth.png"}, sounds = mcl_sounds.node_sound_stone_defaults(), is_ground_content = false, - groups = {cracky = 3, pickaxey=2, material_stone=1}, + groups = {cracky = 3, pickaxey=1, material_stone=1}, _mcl_blast_resistance = 4.2, _mcl_hardness = 1.25, }) @@ -97,7 +97,7 @@ minetest.register_node("mcl_blackstone:blackstone_polished", { tiles = {"mcl_blackstone_polished.png"}, sounds = mcl_sounds.node_sound_stone_defaults(), is_ground_content = false, - groups = {cracky = 3, pickaxey=2, material_stone=1}, + groups = {cracky = 3, pickaxey=1, material_stone=1}, _mcl_blast_resistance = 6, _mcl_hardness = 2, }) @@ -106,7 +106,7 @@ minetest.register_node("mcl_blackstone:blackstone_chiseled_polished", { tiles = {"mcl_blackstone_chiseled_polished.png"}, sounds = mcl_sounds.node_sound_stone_defaults(), is_ground_content = false, - groups = {cracky = 3, pickaxey=2, material_stone=1}, + groups = {cracky = 3, pickaxey=1, material_stone=1}, _mcl_blast_resistance = 6, _mcl_hardness = 1.5, }) @@ -115,7 +115,7 @@ minetest.register_node("mcl_blackstone:blackstone_brick_polished", { tiles = {"mcl_blackstone_polished_bricks.png"}, sounds = mcl_sounds.node_sound_stone_defaults(), is_ground_content = false, - groups = {cracky = 3, pickaxey=2, material_stone=1}, + groups = {cracky = 3, pickaxey=1, material_stone=1}, _mcl_blast_resistance = 6, _mcl_hardness = 1.5, }) @@ -125,7 +125,7 @@ minetest.register_node("mcl_blackstone:quartz_brick", { sounds = mcl_sounds.node_sound_stone_defaults(), is_ground_content = false, sounds = mcl_sounds.node_sound_stone_defaults(), - groups = {cracky = 3, pickaxey=2, material_stone=1}, + groups = {cracky = 3, pickaxey=1, material_stone=1}, _mcl_blast_resistance = 0.8, _mcl_hardness = 0.8, }) From 39b6e41a62e41b86b98af33f4e7e0667df334306 Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Mon, 23 Jan 2023 22:34:22 +0000 Subject: [PATCH 08/25] revert hitbox size for warped fungus --- mods/ITEMS/mcl_crimson/init.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mods/ITEMS/mcl_crimson/init.lua b/mods/ITEMS/mcl_crimson/init.lua index f702d39b6..ebf1b976a 100644 --- a/mods/ITEMS/mcl_crimson/init.lua +++ b/mods/ITEMS/mcl_crimson/init.lua @@ -76,10 +76,10 @@ minetest.register_node("mcl_crimson:warped_fungus", { walkable = false, groups = {dig_immediate=3,mushroom=1,attached_node=1,dig_by_water=1,destroy_by_lava_flow=1,dig_by_piston=1,enderman_takable=1,deco_block=1}, light_source = 1, - selection_box = { +--[[ selection_box = { type = "fixed", fixed = { -3/16, -0.5, -3/16, 3/16, -2/16, 3/16 }, - }, + },]] node_placement_prediction = "", on_rightclick = function(pos, node, pointed_thing, player, itemstack) if pointed_thing:get_wielded_item():get_name() == "mcl_bone_meal:bone_meal" then From dc3eedac5f27dde28c6549bc4958118449e67924 Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Tue, 24 Jan 2023 16:24:35 +0000 Subject: [PATCH 09/25] Add breaking sounds for warped fungus, nether sprouts, warped roots, crimson fungus, crimson roots --- mods/ITEMS/mcl_crimson/init.lua | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/mods/ITEMS/mcl_crimson/init.lua b/mods/ITEMS/mcl_crimson/init.lua index ebf1b976a..e1689b096 100644 --- a/mods/ITEMS/mcl_crimson/init.lua +++ b/mods/ITEMS/mcl_crimson/init.lua @@ -76,6 +76,7 @@ minetest.register_node("mcl_crimson:warped_fungus", { walkable = false, groups = {dig_immediate=3,mushroom=1,attached_node=1,dig_by_water=1,destroy_by_lava_flow=1,dig_by_piston=1,enderman_takable=1,deco_block=1}, light_source = 1, + sounds = mcl_sounds.node_sound_leaves_defaults(), --[[ selection_box = { type = "fixed", fixed = { -3/16, -0.5, -3/16, 3/16, -2/16, 3/16 }, @@ -246,6 +247,7 @@ minetest.register_node("mcl_crimson:nether_sprouts", { walkable = false, buildable_to = true, groups = {dig_immediate=3,vines=1,dig_by_water=1,destroy_by_lava_flow=1,dig_by_piston=1,deco_block=1, shearsy = 1}, + sounds = mcl_sounds.node_sound_leaves_defaults(), selection_box = { type = "fixed", fixed = { -4/16, -0.5, -4/16, 4/16, 0, 4/16 }, @@ -267,6 +269,7 @@ minetest.register_node("mcl_crimson:warped_roots", { walkable = false, buildable_to = true, groups = {dig_immediate=3,vines=1,dig_by_water=1,destroy_by_lava_flow=1,dig_by_piston=1,deco_block=1, shearsy = 1}, + sounds = mcl_sounds.node_sound_leaves_defaults(), selection_box = { type = "fixed", fixed = { -6/16, -0.5, -6/16, 6/16, -4/16, 6/16 }, @@ -449,6 +452,7 @@ minetest.register_node("mcl_crimson:crimson_fungus", { walkable = false, groups = {dig_immediate=3,mushroom=1,attached_node=1,dig_by_water=1,destroy_by_lava_flow=1,dig_by_piston=1,enderman_takable=1,deco_block=1}, light_source = 1, + sounds = mcl_sounds.node_sound_leaves_defaults(), selection_box = { type = "fixed", fixed = { -3/16, -0.5, -3/16, 3/16, -2/16, 3/16 }, @@ -485,6 +489,7 @@ minetest.register_node("mcl_crimson:crimson_roots", { walkable = false, buildable_to = true, groups = {dig_immediate=3,vines=1,dig_by_water=1,destroy_by_lava_flow=1,dig_by_piston=1,deco_block=1, shearsy = 1}, + sounds = mcl_sounds.node_sound_leaves_defaults(), selection_box = { type = "fixed", fixed = { -6/16, -0.5, -6/16, 6/16, -4/16, 6/16 }, From 6f22d7daa477d6f82e8737270f1568e5f485995b Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Tue, 24 Jan 2023 17:15:22 +0000 Subject: [PATCH 10/25] Add node breaking logic to twisting vines and weeping vines breaking twisting vines will break the ones above them, breaking weeping vines breaks the ones below them --- mods/ITEMS/mcl_crimson/init.lua | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/mods/ITEMS/mcl_crimson/init.lua b/mods/ITEMS/mcl_crimson/init.lua index e1689b096..6d5d1e9ec 100644 --- a/mods/ITEMS/mcl_crimson/init.lua +++ b/mods/ITEMS/mcl_crimson/init.lua @@ -149,6 +149,16 @@ minetest.register_node("mcl_crimson:twisting_vines", { end return itemstack end, +--breaking twisting vines breaks the vines above logic + on_dig = function(pos, node, digger) + local above = {x=pos.x, y=pos.y+1, z=pos.z} + local abovenode = minetest.get_node(above) + minetest.node_dig(pos, node, digger) + if abovenode.name == node.name and (not mcl_core.check_vines_supported(above, abovenode)) then + minetest.registered_nodes[node.name].on_dig(above, node, digger) + end + end, + drop = { max_items = 1, items = { @@ -216,6 +226,17 @@ minetest.register_node("mcl_crimson:weeping_vines", { end return itemstack end, +--breaking weeping vines breaks the vines below logic + on_dig = function(pos, node, digger) + local below = {x=pos.x, y=pos.y-1, z=pos.z} + local belownode = minetest.get_node(below) + minetest.node_dig(pos, node, digger) + if belownode.name == node.name and (not mcl_core.check_vines_supported(below, belownode)) then + minetest.registered_nodes[node.name].on_dig(below, node, digger) + end + end, + + drop = { max_items = 1, items = { From fb8060c36630559c77638137d589e50f7e91d33a Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Wed, 25 Jan 2023 04:06:59 +0000 Subject: [PATCH 11/25] lower hardness of warped wart block and shroomlight block to match nether wart block --- mods/ITEMS/mcl_crimson/init.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mods/ITEMS/mcl_crimson/init.lua b/mods/ITEMS/mcl_crimson/init.lua index 6d5d1e9ec..b597c3ada 100644 --- a/mods/ITEMS/mcl_crimson/init.lua +++ b/mods/ITEMS/mcl_crimson/init.lua @@ -317,7 +317,7 @@ minetest.register_node("mcl_crimson:warped_wart_block", { dug={name="default_dirt_footstep", gain=1.5}, } ), - _mcl_hardness = 2, + _mcl_hardness = 1, }) minetest.register_node("mcl_crimson:shroomlight", { @@ -331,7 +331,7 @@ minetest.register_node("mcl_crimson:shroomlight", { dug={name="default_dirt_footstep", gain=1.5}, } ), - _mcl_hardness = 2, + _mcl_hardness = 1, }) minetest.register_node("mcl_crimson:warped_hyphae", { From 1f09c0a12821ed62f92eca60a843d44757bd2cfb Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Wed, 25 Jan 2023 05:47:41 +0000 Subject: [PATCH 12/25] Make weeping vines and twisting vines break the same speed as regular vines --- mods/ITEMS/mcl_crimson/init.lua | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/mods/ITEMS/mcl_crimson/init.lua b/mods/ITEMS/mcl_crimson/init.lua index b597c3ada..73008192a 100644 --- a/mods/ITEMS/mcl_crimson/init.lua +++ b/mods/ITEMS/mcl_crimson/init.lua @@ -113,7 +113,8 @@ minetest.register_node("mcl_crimson:twisting_vines", { walkable = false, climbable = true, buildable_to = true, - groups = {dig_immediate=3,vines=1,dig_by_water=1,destroy_by_lava_flow=1,dig_by_piston=1,deco_block=1, shearsy = 1}, + groups = {handy=1, axey=1, shearsy=1, swordy=1, vines=1, + dig_by_water=1, destroy_by_lava_flow=1, dig_by_piston=1, deco_block=1}, sounds = mcl_sounds.node_sound_leaves_defaults(), selection_box = { type = "fixed", @@ -177,7 +178,8 @@ minetest.register_node("mcl_crimson:twisting_vines", { "mcl_crimson:twisting_vines", "mcl_crimson:twisting_vines", }, - _mcl_blast_resistance = 0, + _mcl_blast_resistance = 0.2, + _mcl_hardness = 0.2, }) minetest.register_node("mcl_crimson:weeping_vines", { @@ -190,7 +192,8 @@ minetest.register_node("mcl_crimson:weeping_vines", { walkable = false, climbable = true, buildable_to = true, - groups = {dig_immediate=3,vines=1,dig_by_water=1,destroy_by_lava_flow=1,dig_by_piston=1,deco_block=1, shearsy = 1}, + groups = {handy=1, axey=1, shearsy=1, swordy=1, vines=1, dig_by_water=1, + destroy_by_lava_flow=1, dig_by_piston=1, deco_block=1}, sounds = mcl_sounds.node_sound_leaves_defaults(), selection_box = { type = "fixed", @@ -255,7 +258,8 @@ minetest.register_node("mcl_crimson:weeping_vines", { "mcl_crimson:weeping_vines", "mcl_crimson:weeping_vines", }, - _mcl_blast_resistance = 0, + _mcl_blast_resistance = 0.2, + _mcl_hardness = 0.2, }) minetest.register_node("mcl_crimson:nether_sprouts", { From 1a495dd63a932a1bba67daa699232c4e8ce34ff4 Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Mon, 30 Jan 2023 05:03:50 +0000 Subject: [PATCH 13/25] Make ancient debris smeltable in a blast furnace --- mods/ITEMS/mcl_nether/init.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mods/ITEMS/mcl_nether/init.lua b/mods/ITEMS/mcl_nether/init.lua index 204fcf88d..7a5727cfa 100644 --- a/mods/ITEMS/mcl_nether/init.lua +++ b/mods/ITEMS/mcl_nether/init.lua @@ -57,7 +57,7 @@ minetest.register_node("mcl_nether:ancient_debris", { stack_max = 64, tiles = {"mcl_nether_ancient_debris_top.png", "mcl_nether_ancient_debris_side.png"}, is_ground_content = true, - groups = {pickaxey=4, building_block=1, material_stone=1, xp=0}, + groups = {pickaxey=4, building_block=1, material_stone=1, xp=0, blast_furnace_smeltable = 1}, drop = "mcl_nether:ancient_debris", sounds = mcl_sounds.node_sound_stone_defaults(), _mcl_blast_resistance = 1200, From a3fe41128fca5b652752c8e622ed505a5ab6400a Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Mon, 30 Jan 2023 05:38:33 +0000 Subject: [PATCH 14/25] Make netherite ingot crafting shapeless --- mods/ITEMS/mcl_nether/init.lua | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mods/ITEMS/mcl_nether/init.lua b/mods/ITEMS/mcl_nether/init.lua index 7a5727cfa..f3370ba39 100644 --- a/mods/ITEMS/mcl_nether/init.lua +++ b/mods/ITEMS/mcl_nether/init.lua @@ -389,12 +389,12 @@ minetest.register_craft({ }) minetest.register_craft({ + type = "shapeless", output = "mcl_nether:netherite_ingot", recipe = { - {"mcl_nether:netherite_scrap", "mcl_nether:netherite_scrap", "mcl_nether:netherite_scrap"}, - {"mcl_nether:netherite_scrap", "mcl_core:gold_ingot", "mcl_core:gold_ingot"}, - {"mcl_core:gold_ingot", "mcl_core:gold_ingot", ""}, - } + "mcl_nether:netherite_scrap", "mcl_nether:netherite_scrap", "mcl_nether:netherite_scrap", + "mcl_nether:netherite_scrap", "mcl_core:gold_ingot", "mcl_core:gold_ingot", + "mcl_core:gold_ingot", "mcl_core:gold_ingot", }, }) minetest.register_craft({ From 32b5b435c53aa063e391c207da57adbc545d8128 Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Mon, 30 Jan 2023 17:09:50 +0000 Subject: [PATCH 15/25] Make weeping vines and twisting vines break instantly Partial revert of previous commit, they should break instantly --- mods/ITEMS/mcl_crimson/init.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mods/ITEMS/mcl_crimson/init.lua b/mods/ITEMS/mcl_crimson/init.lua index 73008192a..7e45b914a 100644 --- a/mods/ITEMS/mcl_crimson/init.lua +++ b/mods/ITEMS/mcl_crimson/init.lua @@ -113,7 +113,7 @@ minetest.register_node("mcl_crimson:twisting_vines", { walkable = false, climbable = true, buildable_to = true, - groups = {handy=1, axey=1, shearsy=1, swordy=1, vines=1, + groups = {dig_immediate=3, handy=1, axey=1, shearsy=1, swordy=1, vines=1, dig_by_water=1, destroy_by_lava_flow=1, dig_by_piston=1, deco_block=1}, sounds = mcl_sounds.node_sound_leaves_defaults(), selection_box = { @@ -192,7 +192,7 @@ minetest.register_node("mcl_crimson:weeping_vines", { walkable = false, climbable = true, buildable_to = true, - groups = {handy=1, axey=1, shearsy=1, swordy=1, vines=1, dig_by_water=1, + groups = {dig_immediate=3, handy=1, axey=1, shearsy=1, swordy=1, vines=1, dig_by_water=1, destroy_by_lava_flow=1, dig_by_piston=1, deco_block=1}, sounds = mcl_sounds.node_sound_leaves_defaults(), selection_box = { From 88a7a8afab2335029bced09fac8672c95421d49f Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Thu, 2 Feb 2023 21:37:23 +0000 Subject: [PATCH 16/25] Removed handy, axey, swordy, from nether vines & removed useless comments --- mods/ITEMS/mcl_crimson/init.lua | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/mods/ITEMS/mcl_crimson/init.lua b/mods/ITEMS/mcl_crimson/init.lua index 7e45b914a..f0b63adab 100644 --- a/mods/ITEMS/mcl_crimson/init.lua +++ b/mods/ITEMS/mcl_crimson/init.lua @@ -113,8 +113,7 @@ minetest.register_node("mcl_crimson:twisting_vines", { walkable = false, climbable = true, buildable_to = true, - groups = {dig_immediate=3, handy=1, axey=1, shearsy=1, swordy=1, vines=1, - dig_by_water=1, destroy_by_lava_flow=1, dig_by_piston=1, deco_block=1}, + groups = {dig_immediate=3, shearsy=1, vines=1, dig_by_water=1, destroy_by_lava_flow=1, dig_by_piston=1, deco_block=1}, sounds = mcl_sounds.node_sound_leaves_defaults(), selection_box = { type = "fixed", @@ -131,9 +130,8 @@ minetest.register_node("mcl_crimson:twisting_vines", { if not minetest.is_creative_enabled(clicker:get_player_name()) then itemstack:take_item() end ---placement checks sucess, put twisting vine + grow_vines(pos, 1, "mcl_crimson:twisting_vines") ---add sound to vine placement local idef = itemstack:get_definition() local itemstack, success = minetest.item_place_node(itemstack, placer, pointed_thing) if success then @@ -150,7 +148,6 @@ minetest.register_node("mcl_crimson:twisting_vines", { end return itemstack end, ---breaking twisting vines breaks the vines above logic on_dig = function(pos, node, digger) local above = {x=pos.x, y=pos.y+1, z=pos.z} local abovenode = minetest.get_node(above) @@ -192,8 +189,7 @@ minetest.register_node("mcl_crimson:weeping_vines", { walkable = false, climbable = true, buildable_to = true, - groups = {dig_immediate=3, handy=1, axey=1, shearsy=1, swordy=1, vines=1, dig_by_water=1, - destroy_by_lava_flow=1, dig_by_piston=1, deco_block=1}, + groups = {dig_immediate=3, shearsy=1, vines=1, dig_by_water=1, destroy_by_lava_flow=1, dig_by_piston=1, deco_block=1}, sounds = mcl_sounds.node_sound_leaves_defaults(), selection_box = { type = "fixed", @@ -210,9 +206,7 @@ minetest.register_node("mcl_crimson:weeping_vines", { if not minetest.is_creative_enabled(clicker:get_player_name()) then itemstack:take_item() end ---placement check sucess, grow weeping vine grow_vines(pos, 1, "mcl_crimson:weeping_vines", -1) ---add sound to placement local idef = itemstack:get_definition() local itemstack, success = minetest.item_place_node(itemstack, placer, pointed_thing) if success then @@ -229,7 +223,7 @@ minetest.register_node("mcl_crimson:weeping_vines", { end return itemstack end, ---breaking weeping vines breaks the vines below logic + on_dig = function(pos, node, digger) local below = {x=pos.x, y=pos.y-1, z=pos.z} local belownode = minetest.get_node(below) From 659f11bf6f6a111bda51a472b4b3567e3625838a Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Thu, 2 Feb 2023 22:08:37 +0000 Subject: [PATCH 17/25] Fixed up indentation and removed excess blank lines --- mods/ITEMS/mcl_crimson/init.lua | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/mods/ITEMS/mcl_crimson/init.lua b/mods/ITEMS/mcl_crimson/init.lua index f0b63adab..496379038 100644 --- a/mods/ITEMS/mcl_crimson/init.lua +++ b/mods/ITEMS/mcl_crimson/init.lua @@ -76,7 +76,7 @@ minetest.register_node("mcl_crimson:warped_fungus", { walkable = false, groups = {dig_immediate=3,mushroom=1,attached_node=1,dig_by_water=1,destroy_by_lava_flow=1,dig_by_piston=1,enderman_takable=1,deco_block=1}, light_source = 1, - sounds = mcl_sounds.node_sound_leaves_defaults(), + sounds = mcl_sounds.node_sound_leaves_defaults(), --[[ selection_box = { type = "fixed", fixed = { -3/16, -0.5, -3/16, 3/16, -2/16, 3/16 }, @@ -130,12 +130,11 @@ minetest.register_node("mcl_crimson:twisting_vines", { if not minetest.is_creative_enabled(clicker:get_player_name()) then itemstack:take_item() end - grow_vines(pos, 1, "mcl_crimson:twisting_vines") local idef = itemstack:get_definition() local itemstack, success = minetest.item_place_node(itemstack, placer, pointed_thing) - if success then - if idef.sounds and idef.sounds.place then + if success then + if idef.sounds and idef.sounds.place then minetest.sound_play(idef.sounds.place, {pos=above, gain=1}, true) end end @@ -209,8 +208,8 @@ minetest.register_node("mcl_crimson:weeping_vines", { grow_vines(pos, 1, "mcl_crimson:weeping_vines", -1) local idef = itemstack:get_definition() local itemstack, success = minetest.item_place_node(itemstack, placer, pointed_thing) - if success then - if idef.sounds and idef.sounds.place then + if success then + if idef.sounds and idef.sounds.place then minetest.sound_play(idef.sounds.place, {pos=above, gain=1}, true) end end @@ -231,9 +230,7 @@ minetest.register_node("mcl_crimson:weeping_vines", { if belownode.name == node.name and (not mcl_core.check_vines_supported(below, belownode)) then minetest.registered_nodes[node.name].on_dig(below, node, digger) end - end, - - + end, drop = { max_items = 1, items = { @@ -323,7 +320,7 @@ minetest.register_node("mcl_crimson:shroomlight", { tiles = {"shroomlight.png"}, groups = {handy = 1, hoey = 7, swordy = 1, deco_block = 1}, light_source = minetest.LIGHT_MAX, - sounds = mcl_sounds.node_sound_leaves_defaults( + sounds = mcl_sounds.node_sound_leaves_defaults( { footstep={name="default_dirt_footstep", gain=0.7}, dug={name="default_dirt_footstep", gain=1.5}, From b4719599b5b245f0717a11aff1cabd4531289b2c Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Thu, 2 Feb 2023 22:30:15 +0000 Subject: [PATCH 18/25] Fix up indentation --- mods/ITEMS/mcl_crimson/init.lua | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mods/ITEMS/mcl_crimson/init.lua b/mods/ITEMS/mcl_crimson/init.lua index 496379038..1053cd378 100644 --- a/mods/ITEMS/mcl_crimson/init.lua +++ b/mods/ITEMS/mcl_crimson/init.lua @@ -131,8 +131,8 @@ minetest.register_node("mcl_crimson:twisting_vines", { itemstack:take_item() end grow_vines(pos, 1, "mcl_crimson:twisting_vines") - local idef = itemstack:get_definition() - local itemstack, success = minetest.item_place_node(itemstack, placer, pointed_thing) + local idef = itemstack:get_definition() + local itemstack, success = minetest.item_place_node(itemstack, placer, pointed_thing) if success then if idef.sounds and idef.sounds.place then minetest.sound_play(idef.sounds.place, {pos=above, gain=1}, true) @@ -206,8 +206,8 @@ minetest.register_node("mcl_crimson:weeping_vines", { itemstack:take_item() end grow_vines(pos, 1, "mcl_crimson:weeping_vines", -1) - local idef = itemstack:get_definition() - local itemstack, success = minetest.item_place_node(itemstack, placer, pointed_thing) + local idef = itemstack:get_definition() + local itemstack, success = minetest.item_place_node(itemstack, placer, pointed_thing) if success then if idef.sounds and idef.sounds.place then minetest.sound_play(idef.sounds.place, {pos=above, gain=1}, true) From 27f5a94c6a0839b3cc49fba0e5c5871a140ee818 Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Thu, 2 Feb 2023 22:36:33 +0000 Subject: [PATCH 19/25] Fix up indentation for warped and crimson wart block sounds --- mods/ITEMS/mcl_crimson/init.lua | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/mods/ITEMS/mcl_crimson/init.lua b/mods/ITEMS/mcl_crimson/init.lua index 1053cd378..88fdc6641 100644 --- a/mods/ITEMS/mcl_crimson/init.lua +++ b/mods/ITEMS/mcl_crimson/init.lua @@ -306,13 +306,12 @@ minetest.register_node("mcl_crimson:warped_wart_block", { description = S("Warped Wart Block"), tiles = {"warped_wart_block.png"}, groups = {handy = 1, hoey = 7, swordy = 1, deco_block = 1}, - sounds = mcl_sounds.node_sound_leaves_defaults( -{ + _mcl_hardness = 1, + sounds = mcl_sounds.node_sound_leaves_defaults({ footstep={name="default_dirt_footstep", gain=0.7}, dug={name="default_dirt_footstep", gain=1.5}, - } -), - _mcl_hardness = 1, + }), + }) minetest.register_node("mcl_crimson:shroomlight", { @@ -320,13 +319,11 @@ minetest.register_node("mcl_crimson:shroomlight", { tiles = {"shroomlight.png"}, groups = {handy = 1, hoey = 7, swordy = 1, deco_block = 1}, light_source = minetest.LIGHT_MAX, - sounds = mcl_sounds.node_sound_leaves_defaults( -{ + _mcl_hardness = 1, + sounds = mcl_sounds.node_sound_leaves_defaults({ footstep={name="default_dirt_footstep", gain=0.7}, dug={name="default_dirt_footstep", gain=1.5}, - } -), - _mcl_hardness = 1, + }), }) minetest.register_node("mcl_crimson:warped_hyphae", { From eae1ee7cee00a95cf102def69229ad4d155625f0 Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Thu, 2 Feb 2023 22:39:37 +0000 Subject: [PATCH 20/25] Fix indentation for shapeless type @ netherite ingot --- mods/ITEMS/mcl_nether/init.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mods/ITEMS/mcl_nether/init.lua b/mods/ITEMS/mcl_nether/init.lua index f3370ba39..3f63c4333 100644 --- a/mods/ITEMS/mcl_nether/init.lua +++ b/mods/ITEMS/mcl_nether/init.lua @@ -389,7 +389,7 @@ minetest.register_craft({ }) minetest.register_craft({ - type = "shapeless", + type = "shapeless", output = "mcl_nether:netherite_ingot", recipe = { "mcl_nether:netherite_scrap", "mcl_nether:netherite_scrap", "mcl_nether:netherite_scrap", From 89eb458df7d74e40a84afab21870ca20fbc7a3c4 Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Thu, 2 Feb 2023 22:42:44 +0000 Subject: [PATCH 21/25] Fix up indentation for warped and crimson wart block sounds part 2 --- mods/ITEMS/mcl_crimson/init.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mods/ITEMS/mcl_crimson/init.lua b/mods/ITEMS/mcl_crimson/init.lua index 88fdc6641..4afaf91ba 100644 --- a/mods/ITEMS/mcl_crimson/init.lua +++ b/mods/ITEMS/mcl_crimson/init.lua @@ -310,7 +310,7 @@ minetest.register_node("mcl_crimson:warped_wart_block", { sounds = mcl_sounds.node_sound_leaves_defaults({ footstep={name="default_dirt_footstep", gain=0.7}, dug={name="default_dirt_footstep", gain=1.5}, - }), + }), }) @@ -323,7 +323,7 @@ minetest.register_node("mcl_crimson:shroomlight", { sounds = mcl_sounds.node_sound_leaves_defaults({ footstep={name="default_dirt_footstep", gain=0.7}, dug={name="default_dirt_footstep", gain=1.5}, - }), + }), }) minetest.register_node("mcl_crimson:warped_hyphae", { From 16a6dcb66c96840e69e834ed8b9ff936b48a2e4d Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Thu, 2 Feb 2023 22:45:06 +0000 Subject: [PATCH 22/25] Completely remove selection box for warped fungus Recommended by Michael --- mods/ITEMS/mcl_crimson/init.lua | 4 ---- 1 file changed, 4 deletions(-) diff --git a/mods/ITEMS/mcl_crimson/init.lua b/mods/ITEMS/mcl_crimson/init.lua index 4afaf91ba..055cc9359 100644 --- a/mods/ITEMS/mcl_crimson/init.lua +++ b/mods/ITEMS/mcl_crimson/init.lua @@ -77,10 +77,6 @@ minetest.register_node("mcl_crimson:warped_fungus", { groups = {dig_immediate=3,mushroom=1,attached_node=1,dig_by_water=1,destroy_by_lava_flow=1,dig_by_piston=1,enderman_takable=1,deco_block=1}, light_source = 1, sounds = mcl_sounds.node_sound_leaves_defaults(), ---[[ selection_box = { - type = "fixed", - fixed = { -3/16, -0.5, -3/16, 3/16, -2/16, 3/16 }, - },]] node_placement_prediction = "", on_rightclick = function(pos, node, pointed_thing, player, itemstack) if pointed_thing:get_wielded_item():get_name() == "mcl_bone_meal:bone_meal" then From cf05771e3051503bfcdb92f4195cffe870572d7b Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Thu, 2 Feb 2023 23:12:09 +0000 Subject: [PATCH 23/25] remove unnecessary blank line --- mods/ITEMS/mcl_crimson/init.lua | 1 - 1 file changed, 1 deletion(-) diff --git a/mods/ITEMS/mcl_crimson/init.lua b/mods/ITEMS/mcl_crimson/init.lua index 055cc9359..f0d1318fe 100644 --- a/mods/ITEMS/mcl_crimson/init.lua +++ b/mods/ITEMS/mcl_crimson/init.lua @@ -307,7 +307,6 @@ minetest.register_node("mcl_crimson:warped_wart_block", { footstep={name="default_dirt_footstep", gain=0.7}, dug={name="default_dirt_footstep", gain=1.5}, }), - }) minetest.register_node("mcl_crimson:shroomlight", { From bc4d9211cb5edc689e2169df1c10b8a1a95f22a1 Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Fri, 3 Feb 2023 00:43:17 +0000 Subject: [PATCH 24/25] Update nether vine breaking logic with vector.offset --- mods/ITEMS/mcl_crimson/init.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mods/ITEMS/mcl_crimson/init.lua b/mods/ITEMS/mcl_crimson/init.lua index f0d1318fe..0c61f3cee 100644 --- a/mods/ITEMS/mcl_crimson/init.lua +++ b/mods/ITEMS/mcl_crimson/init.lua @@ -144,7 +144,7 @@ minetest.register_node("mcl_crimson:twisting_vines", { return itemstack end, on_dig = function(pos, node, digger) - local above = {x=pos.x, y=pos.y+1, z=pos.z} + local above = vector.offset(pos,0,1,0) local abovenode = minetest.get_node(above) minetest.node_dig(pos, node, digger) if abovenode.name == node.name and (not mcl_core.check_vines_supported(above, abovenode)) then @@ -220,7 +220,7 @@ minetest.register_node("mcl_crimson:weeping_vines", { end, on_dig = function(pos, node, digger) - local below = {x=pos.x, y=pos.y-1, z=pos.z} + local below = vector.offset(pos,0,-1,0) local belownode = minetest.get_node(below) minetest.node_dig(pos, node, digger) if belownode.name == node.name and (not mcl_core.check_vines_supported(below, belownode)) then From 08df1fe02fb9b8c3fd385f19b6421eea84d55bd7 Mon Sep 17 00:00:00 2001 From: SmokeyDope Date: Fri, 3 Feb 2023 00:50:25 +0000 Subject: [PATCH 25/25] Update overworld vine breaking logic with vector.offset --- mods/ITEMS/mcl_core/nodes_climb.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mods/ITEMS/mcl_core/nodes_climb.lua b/mods/ITEMS/mcl_core/nodes_climb.lua index 1a6780618..8893db21b 100644 --- a/mods/ITEMS/mcl_core/nodes_climb.lua +++ b/mods/ITEMS/mcl_core/nodes_climb.lua @@ -158,7 +158,7 @@ minetest.register_node("mcl_core:vine", { -- If dug, also dig a “dependant” vine below it. -- A vine is dependant if it hangs from this node and has no supporting block. on_dig = function(pos, node, digger) - local below = {x=pos.x, y=pos.y-1, z=pos.z} + local below = vector.offset(pos,0,-1,0) local belownode = minetest.get_node(below) minetest.node_dig(pos, node, digger) if belownode.name == node.name and (not mcl_core.check_vines_supported(below, belownode)) then